Add topology as sample filter input#1728
Open
nicolemarsaglia wants to merge 10 commits into
Open
Conversation
…Alpine-DAV/ascent into task/2026_05_19_sample_topology
cyrush
requested changes
Jul 17, 2026
cyrush
left a comment
cyrush
left a comment
Member
There was a problem hiding this comment.
Looks good!
Two suggestions:
See inline suggestion about using a conduit helper to simplify grabbing domain pointers.
For the topology sample outputs (the plane and sphere results) -- lets also render those and have baselines for them. Helps us visually confirm the sampling is working as expected.
| conduit::Node sample_mesh; | ||
| if(rank == 0) | ||
| { | ||
| std::vector<const conduit::Node*> domains; |
Member
There was a problem hiding this comment.
conduit provides a helper to grab domain pts regardless of single or multiple domain meshes, here is an example:
lets use this to reduce code
…eplace how we are grabbing domains in a node
cyrush
reviewed
Jul 17, 2026
| domains.push_back(&blueprint_data->child(i)); | ||
| } | ||
| } | ||
| const std::vector<const Node *> domains = blueprint::mesh::domains(*blueprint_data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can specify a topology that is present in their dataset to use as the input for the sample filter